RFR: 8247918: Clarify Reader.skip behavior for end of stream

Naoto Sato naoto at openjdk.java.net
Mon Feb 8 23:22:44 UTC 2021


On Mon, 8 Feb 2021 22:58:13 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/FilterReader.java line 81:
>> 
>>> 79:      * {@inheritDoc}
>>> 80:      *
>>> 81:      * @throws     IllegalArgumentException  If {@code n} is negative and the
>> 
>> Does this have to be different from the `Reader.skip()`'s description? Since the contained reader implements `Reader` (throws IAE as a contract), that condition after `and` is always true?
>
> This came from some `Reader`s, e.g., `CharArrayReader`, `StringReader`, overriding `skip()` _not_ to throw an IAE. But at the specification level perhaps this should not be recognized.

Makes sense. Then I would let CSR decide whether to include the description or not.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2274


More information about the core-libs-dev mailing list