RFR: JDK-8261237: remove isClassPathAttributePresent method [v2]
Aleksey Shipilev
shade at openjdk.java.net
Tue Feb 9 08:52:17 UTC 2021
On Tue, 9 Feb 2021 08:30:54 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Hello,
>> Currently in jdk/internal/vm/VMSupport.java , we create a JarFile without a related finally clause or try with resources. That should better be changed.
>> See also the Sonar check result :
>>
>> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&open=AXcqM8zf8sPJZZzON5qG&resolved=false&severities=BLOCKER&types=BUG
>>
>> public static boolean isClassPathAttributePresent(String path) {
>> try {
>> Manifest man = (new JarFile(path)).getManifest();
>> Use try-with-resources or close this "JarFile" in a "finally" clause.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove isClassPathAttributePresent
Marked as reviewed by shade (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/2429
More information about the core-libs-dev
mailing list