RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v7]

[Michael McMahon]

On Tue, 9 Feb 2021 15:33:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 840:
> 
>> 838:                 throw e;
>> 839:             // Object could be a Unix domain socket
>> 840:             try {
> 
> Thanks for the updates, I think the fallback checking is correct everywhere now.
> What would you think about inverting the above so that it only checks for a socket file when followLinks && e.lastError() == ERROR_CANT_ACCESS_FILE. That would make it more consistent with the new code in WIndowsFileSystemProvider.

Okay. No problem. The next revision also includes an updated test where I found some socket files weren't being cleaned up at the end of the test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2424