RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v4]

[Severin Gehwolf]

On Fri, 12 Feb 2021 10:19:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi Severin,
>> Thanks for doing this!  Sorry for taking so long to review this change.  The change looks good.  Before pushing it, could you add a comment explaining what the code in lines 185-194 of CgroupSubsystemFactory.java is doing?  Also, please don't overwrite the fix for JDK-8257746.
>> Thanks again! Harold
>
> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too.

Hi Harold,

> Thanks for doing this! Sorry for taking so long to review this change. The change looks good.

Thanks for the review!

> Before pushing it, could you add a comment explaining what the code in lines 185-194 of CgroupSubsystemFactory.java is doing?

Done.

> Also, please don't overwrite the fix for JDK-8257746.

AFAIK this patch doesn't touch this code. So this should not happen (overwrite of the fix). FWIW, once this is in I intend to propose a patch which adds a regression test for JDK-8257746. It would depend on this change.

Thanks,
Severin

-------------

PR: https://git.openjdk.java.net/jdk/pull/1393