RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v9]

[Alan Bateman]

On Thu, 11 Feb 2021 09:19:05 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Could I get the following change reviewed please? It fixes a problem (in JEP380) on Windows where some file operations on Unix domain sockets were not working and led to the feature being disabled on Windows 2019 Server in JDK 16. So, the fix re-enables the feature on all versions of Windows that support it.
>> 
>> The test checks all the file APIs that were affected by the problem. The change touches the code that handles symbolic links in Windows (since they are implemented as NTFS reparse points, like Unix sockets), but I didn't add any specific testing in this area, as I assume the existing unit tests for NIO symbolic links should cover that. If I should add more tests here, then I can do that.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - Merge branch 'master' into 8252971-socket-attributes
>  - Rearrange test in WindowsPath. Change to Security.java test to explicitly delete socket files
>  - Merge branch 'master' into 8252971-socket-attributes
>  - update
>  - fix mistake in last push
>  - update
>  - Merge branch 'master' into 8252971-socket-attributes
>  - add specific check for unix domain socket
>  - Merge branch 'master' into 8252971-socket-attributes
>  - update
>  - ... and 7 more: https://git.openjdk.java.net/jdk/compare/c6c9f6f9...11ae5e72

Thanks for the updates, I think you've got this to a good place now.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2424