RFR: 8261938: ASN1Formatter.annotate should not return in the finally block

[Jie Fu]

Hi all,

ASN1Formatter.annotate should be able to throw an IOException according to this comment [1].
But it fails to do so due to the return [2] in the finally block, which would swallow the IOException.

Generally, it seems not good to put a return statement in a finally block because it would overwrite other return-statements or Exceptions [3].

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/hexdump/ASN1Formatter.java#L113
[2] https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/hexdump/ASN1Formatter.java#L120
[3] https://stackoverflow.com/questions/17481251/finally-block-does-not-complete-normally-eclipse-warning

-------------

Commit messages:
 - 8261938: ASN1Formatter.annotate should not return in the finally block

Changes: https://git.openjdk.java.net/jdk/pull/2620/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2620&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261938
  Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2620.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2620/head:pull/2620

PR: https://git.openjdk.java.net/jdk/pull/2620