RFR: JDK-8262199: issue in jli args.c [v3]

Matthias Baesken mbaesken at openjdk.java.net
Thu Feb 25 16:44:01 UTC 2021


On Thu, 25 Feb 2021 16:07:36 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove fclose before exit
>
> src/java.base/share/native/libjli/args.c line 378:
> 
>> 376:         if (st.st_size > MAX_ARGF_SIZE) {
>> 377:             JLI_ReportMessage(CFG_ERROR10, MAX_ARGF_SIZE);
>> 378:             reportAndExit(NULL, NULL);
> 
> This should be just one statement,
>     reportAndExit(CFG_ERROR10, MAX_ARGF_SIZE);
> or?

I think that did not work because it does not fit the param types of reportAndExit but I can simplify it otherwise.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2692


More information about the core-libs-dev mailing list