RFR: 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now" [v2]

Attila Szegedi attila at openjdk.java.net
Sat Feb 27 20:12:39 UTC 2021


On Thu, 25 Feb 2021 15:34:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Attila Szegedi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> test/jdk/jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java line 79:
> 
>> 77: 
>> 78:     public static void main(String[] args) {
>> 79:         for (int count = 0; count < MAX_ITERATIONS; ++count) {
> 
> Here and later: use postfix `count++`, regular style?

Old habits die hard; I think I started doing this about 30 years ago when writing C code against a compiler on Atari ST that emitted more efficient MC68000 code for `++i` than for `i++`. I guess it's time to unlearn this :-) Of course, if you wanted to get the fastest code, you would've counted _decrementing to zero_ to let the compiler use the DBRA (decrement and branch) instruction.

It's funny how I _don't_ miss those days.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2617


More information about the core-libs-dev mailing list