[jdk16] Integrated: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Jan 6 12:22:12 UTC 2021


On Tue, 5 Jan 2021 15:33:54 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Hi,
> this patch fixes an oversight where the address() method in FileChannelImpl.Unmapper does not take into account the value of `pagePosition` - this leads to a situation in which, effectively, the specified offset when mapping the segment is ignored by the runtime (because base address will always be aligned to some known quantity - which is OS/platform dependent).
> 
> To test this I had to break open into FileChannelImpl and ready the granularity.

This pull request has now been integrated.

Changeset: e66187d8
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/jdk16/commit/e66187d8
Stats:     23 lines in 2 files changed: 22 ins; 0 del; 1 mod

8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition

Co-authored-by: Uwe Schindler <uschindler at openjdk.org>
Reviewed-by: alanb

-------------

PR: https://git.openjdk.java.net/jdk16/pull/84


More information about the core-libs-dev mailing list