RFR: JDK-8258755: jpackage: Invalid 32-bit exe when building app-image

[Andy Herrick]

On Tue, 12 Jan 2021 20:49:52 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Platform.java line 127:
> 
>> 125:         return is64b;
>> 126:     }
>> 127: 
> 
> This function makes sense only on Windows platform. Why not add it to Windows-specific class, e.g. WixSourcesBuilder?
> 
> The value should not be based on arch of OS, but on arch of JDK. msi installer produced by jpackage from 32bit JDK (in case somebody would build 32bit OpenJDK) would contain 32bit Java runtime regardless on 64bit or 32bit Windows it will be executed. I'd use `sun.arch.data.model` instead of `os.arch`

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2030