RFR: 8259943: FileDescriptor.close0 does not handle EINTR [v2]

Brian Burkhalter brian.burkhalter at oracle.com
Thu Jan 21 19:07:03 UTC 2021



> On Jan 21, 2021, at 11:06 AM, Alan Bateman <alanb at openjdk.java.net> wrote:
> 
> On Thu, 21 Jan 2021 18:56:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> 
>>> Please review this small change to handle `EINTR` from `close()` in `fileDescriptorClose()`. The function `handleGetLength()` is also changed to handle `EINTR` from `fstat64()` to match other uses of `fstat64()` in the file.
>> 
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>  8259943: Suppress RESTARTABLE for non-AIX.
> 
> src/java.base/unix/native/libjava/io_util_md.c line 173:
> 
>> 171:         result = close(fd);
>> 172: #endif
>> 173:         if (result == -1) {
> 
> This needs to be `if (result == -1 && errno != EINTR)`

Yes I already caught and fixed that gaff.

> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/2173



More information about the core-libs-dev mailing list