RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

David Holmes david.holmes at oracle.com
Mon Jan 25 00:27:12 UTC 2021


Alex,

On 20/01/2021 11:47 am, Alex Menkov wrote:
> On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> What do you mean by this? The -J args are not "translated" here but later in TranslateApplicationArgs.
> 
> I meant that they are translated in TranslateApplicationArgs. Looks like it's not clear. Updated the comment as you suggested.

You integrated this change but neither Zhengyu nor myself approved the 
final changes. Zhengyu's Review was prior to the logic fix, and my 
comment "this seems functionally correct" was just a comment and we were 
still discussing the overhead aspect of this.

David
-----

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/2106
> 


More information about the core-libs-dev mailing list