RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]
Mahendra Chhipa
github.com+34924738+mahendrachhipa at openjdk.java.net
Mon Jan 25 19:40:42 UTC 2021
On Fri, 22 Jan 2021 18:09:43 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> NonJavaName Tests updated
>> Used newInstance() method to create the different EnclosingClasses at runtime
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 176:
>
>> 174: }
>> 175:
>> 176: private void check(final Class<?> c, final Class<?> enc,
>
> I see that you make all parameters in all methods final. It just adds noise. Can you leave it out?
To avoid the Checkstyle warnings, I added them.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2170
More information about the core-libs-dev
mailing list