RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

[Mahendra Chhipa]

On Tue, 26 Jan 2021 22:56:25 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented the review comments.
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 158:
> 
>> 156:     private void match(final String actual, final String expected) {
>> 157:         System.out.println("actual:" + actual + "expected:" + expected);
>> 158:         assert ((actual == null && expected == null) || actual.trim().equals(expected.trim()));
> 
> Out of curiousity, why is the trim() now needed ?

expected string having one space as prefixed in some class names incase of pkg1 and pkg2 packages. So trimmig before comparing with actual name:

=================================================
nested class within top level class:
class EnclosingClass$Nested
	is enclosed by:		class EnclosingClass
	has simple name:	`Nested'
	has canonical name:	`EnclosingClass.Nested'
actual:class EnclosingClassexpected:class EnclosingClass

=================================================
nested class within top level class:
class pkg1.pkg2.EnclosingClass$Nested
	is enclosed by:		class pkg1.pkg2.EnclosingClass
	has simple name:	`Nested'
	has canonical name:	`pkg1.pkg2.EnclosingClass.Nested'
actual:class pkg1.pkg2.EnclosingClass**expected: class pkg1.pkg2.EnclosingClass**
==================================================

nested class within top level class:
class pkg1.EnclosingClass$Nested
	is enclosed by:		class pkg1.EnclosingClass
	has simple name:	`Nested'
	has canonical name:	`pkg1.EnclosingClass.Nested'
actual:class pkg1.EnclosingClass**expected: class pkg1.EnclosingClass**

-------------

PR: https://git.openjdk.java.net/jdk/pull/2170