RFR: 8249867: xml declaration is not followed by a newline [v3]

Joe Wang joehw at openjdk.java.net
Fri Jan 29 19:33:48 UTC 2021


On Fri, 29 Jan 2021 17:57:14 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the patch based on review comments. Refer to the previous reviews.
>
> src/java.xml/share/classes/module-info.java line 188:
> 
>> 186:  * </tbody>
>> 187:  * </table>
>> 188:  *
> 
> One question is whether the code samples in the table above should be escaped with {@code }. e.g.:
> 
> <td>
> {@code first line of code;}<br>
> {@code second line of code;}<br>
> </td>

Looks better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2041


More information about the core-libs-dev mailing list