[jdk17] RFR: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF [v2]

[Joe Wang]

On Fri, 2 Jul 2021 19:08:09 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Right. I understand. The intention was, unlike the overridden method that returns 0 if len == 0 and -1 if at the end of the stream, this method returns -1 in both cases. A careful reader, after comparing both methods, would understand correctly that the difference is in the case of "len==0". I'm fine if you think this is good enough. Just a thought though that the statement could be interpreted as if both conditions need to be met at the same time (if "and" is taken as "&&", e.g. if (pos>==count && len==0) ). 
>> 
>> Something like the following might be clearer?
>>      * Unlike the {@link InputStream#read(byte[],int,int) overridden method}
>>      * of {@code InputStream} that returns {@code -1} if the end of the stream
>>      * has been reached and {@code 0} if {@code len == 0}, this method returns
>>      * {@code -1} in both cases.
>> 
>> Just my 2 cents.
>
> Thanks for the suggestion. I am happy with it as is, but I'll hold off integrating it for now and rethink it later.

Ok, good to know. Have a great weekend!

-------------

PR: https://git.openjdk.java.net/jdk17/pull/189