RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v3]

Alexey Semenyuk asemenyuk at openjdk.java.net
Tue Jul 13 17:46:15 UTC 2021


On Tue, 13 Jul 2021 16:39:01 GMT, Andy Herrick <herrick at openjdk.org> wrote:

>> JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers
>
> Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

Changes requested by asemenyuk (Reviewer).

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java line 87:

> 85:         withMenuShortcut = menu;
> 86:         withShortcut = shortcut;
> 87:         if (TKit.isLinux()) {

I'd move add `addRawProperties()` calls to `initialize()` method. This will prevent multiple `addRawProperties()` calls for "linux-shortcut" and "win-shortcut" properties in case `setShortcuts()` method is called multiple times.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4730


More information about the core-libs-dev mailing list