[jdk17] Integrated: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE

Vicente Romero vromero at openjdk.java.net
Tue Jul 13 17:52:28 UTC 2021


On Sat, 10 Jul 2021 19:03:36 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Please review this PR that is fixing a mismatch between the implementation for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its implementation. I made a mistake while working on a recent CSR [JDK-8224985](https://bugs.openjdk.java.net/browse/JDK-8224985) and fixed the API but mistakenly thought that the implementation was in sync with the spec. This is why this change is also including a unit test of the API for `java.lang.constant.DynamicCallSiteDesc` modulo method `resolveCallSiteDesc` which is covered in test `IndyDescTest` in the same test suite. Also this change needs a CSR as while fixing the implementation of method `::withArgs` I realized that the API of the varargs overloaded version of method `::of` needed some rewording too as it is invoking the same private constructor `::withArgs` is invoking. So it didn't make sense for the API of one method to be more restrictive than the other. Please review also the accompanying CSR.
> 
> Thanks,
> Vicente

This pull request has now been integrated.

Changeset: 8583aab3
Author:    Vicente Romero <vromero at openjdk.org>
URL:       https://git.openjdk.java.net/jdk17/commit/8583aab374c3c2ad94c88e7f649d81ce5f319a5f
Stats:     197 lines in 2 files changed: 195 ins; 0 del; 2 mod

8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE

Reviewed-by: jvernee, mchung

-------------

PR: https://git.openjdk.java.net/jdk17/pull/242


More information about the core-libs-dev mailing list