RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v4]
Severin Gehwolf
sgehwolf at openjdk.java.net
Thu Jul 15 13:42:17 UTC 2021
On Thu, 15 Jul 2021 13:09:54 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids controller might not be there (or not fully supported) so it was added as optional , see the coding
>>
>>
>> if (!cg_infos[PIDS_IDX]._data_complete) {
>> log_debug(os, container)("Optional cgroup v1 pids subsystem not found");
>> // keep the other controller info, pids is optional
>> }
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Add hotspot tests
Thanks, I'll test it and review once again. Meanwhile, please merge the master branch into your `JDK-8266490` branch and push so that we get a better ruling of pre-integration tests.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4518
More information about the core-libs-dev
mailing list