RFR: 8268151: Vector API toShuffle optimization [v2]

[Sandhya Viswanathan]

On Thu, 3 Jun 2021 02:31:51 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement review comments
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java line 335:
> 
>> 333:     @ForceInline
>> 334:     private final
>> 335:     VectorShuffle<Byte> toShuffleTemplate(AbstractSpecies<Byte> dsp) {
> 
> Is it better to move this template method to the super class like other APIs?

Yes, can be moved to super class. Done in the updated commit.

> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java line 350:
> 
>> 348:                                      Byte128Shuffle.class, byte.class, VLENGTH,
>> 349:                                      this, VSPECIES,
>> 350:                                      Byte128Vector::toShuffleTemplate);
> 
> ditto

Yes, can be moved to super class. Done in the updated commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4326