RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

[Mandy Chung]

On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> Standardizes and better specifies the errors thrown by LambdaMetafactory, including for inputs that would not be generated by javac.
>> 
>> Does some renaming of core parameters/fields to better reflect their purpose.
>> 
>> In the implementation, stops using ACC_BRIDGE for any methods, which is not a good fit for what these methods do (they don't delegate to each other, but all invoke the same implementation method).
>
> Dan Smith has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix accidentally commented-out parts of test

Looks fine to me.   The CSR was approved for 13 and its fixVersion should be updated to 17.

test/jdk/java/lang/invoke/lambda/MetafactoryArgValidationTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.

copyright year needs update.

-------------

Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4346