RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

Dan Smith dlsmith at openjdk.java.net
Fri Jun 4 22:04:20 UTC 2021


On Fri, 4 Jun 2021 06:16:45 GMT, Peter Levart <plevart at openjdk.org> wrote:

>> Dan Smith has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix accidentally commented-out parts of test
>
> src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java line 69:
> 
>> 67:     final boolean isSerializable;             // Should the returned instance be serializable
>> 68:     final Class<?>[] interfaces;              // Additional interfaces to be implemented
>> 69:     final MethodType[] bridges;               // Signatures of additional methods to bridge
> 
> If you are removing ACC_BRIDGE from additional generated methods, then perhaps this parameter name could also be changed? `altMethods` (as alternative methods perhaps?)

Yes, it was sort of a half-done move. You're right, we should rename these (and, more importantly, in the public LambdaMetafactory API). Done. Also renamed `interfaces` --> `altInterfaces`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4346


More information about the core-libs-dev mailing list