RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v3]

Mandy Chung mchung at openjdk.java.net
Sat Jun 5 00:45:01 UTC 2021


On Fri, 4 Jun 2021 23:41:06 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java line 312:
>> 
>>> 310:      * @return a CallSite whose target can be used to perform capture, generating
>>> 311:      *         instances of the interface named by {@code factoryType}
>>> 312:      * @throws LambdaConversionException If {@code caller} does not have full privilege
>> 
>> Suggestion:
>> 
>>      * @throws LambdaConversionException If {@code caller} does not have {@linkplain Lookup#hasFullPrivilegeAccess full privilege}
>
> It's hard to see in the diff, but this link just appeared in the javadoc a few lines above. Stylistically, doesn't seem like it should be linked again.

I didn't realize it's already linked, thanks.  So what you have is fine then.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4346


More information about the core-libs-dev mailing list