RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v4]

[Mandy Chung]

On Sat, 5 Jun 2021 00:15:25 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> Standardizes and better specifies the errors thrown by LambdaMetafactory, including for inputs that would not be generated by javac.
>> 
>> Does some renaming of core parameters/fields to better reflect their purpose.
>> 
>> In the implementation, stops using ACC_BRIDGE for any methods, which is not a good fit for what these methods do (they don't delegate to each other, but all invoke the same implementation method).
>
> Dan Smith has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix stray renaming
>  - Apply renamings to LambdaProxyClassArchive

Thanks for going beyond the java code.   Looks good.

-------------

Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4346