Integrated: 8266835: Add a --validate option to the jar tool

Jorn Vernee jvernee at openjdk.java.net
Wed Jun 9 18:18:20 UTC 2021


On Tue, 11 May 2021 10:51:18 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> This patch adds a `--validate` option to the jar tool which can be used to validate a jar file that might be malformed. For instance, if a jar is a multi-release jar, it is malformed if different versions expose different APIs.
> 
> The implementation is straight forward since there already exists validation logic that is run when creating or updating a jar. This patch just exposes that logic directly under a new command line flag.
> 
> I've enhanced the existing ApiValidatorTest to also create malformed jars using the zip file APIs (the jar tool does not output malformed jars) and run them through `jar --validate`.
> 
> Note that while the jdk's jar tool does not output malformed jars, third-party archiving tools might, or the jar could have been manually edited.
> 
> Some prior discussion here: https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-May/077420.html
> 
> Testing: running jdk/tools/jar test suite locally, tier 1-3 (in progress), manual testing.

This pull request has now been integrated.

Changeset: 79010f22
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/79010f2254aee8459523800d6049f396b055f123
Stats:     150 lines in 4 files changed: 117 ins; 4 del; 29 mod

8266835: Add a --validate option to the jar tool

Reviewed-by: lancea

-------------

PR: https://git.openjdk.java.net/jdk/pull/3971


More information about the core-libs-dev mailing list