RFR: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling [v2]

Vicente Romero vromero at openjdk.java.net
Thu Jun 10 23:26:21 UTC 2021


> Please review this PR which is just syncing the implementation of DirectMethodHandleDesc.Kind.valueOf(int) with its spec. My reading of the method's spec is that if the value of the `refKind` parameter is: MethodHandleInfo.REF_invokeInterface, then DirectMethodHandleDesc.Kind.valueOf(int, boolean) should be called with a value of `true` for its second argument, currently it is invoked with `false` regardless of the value of the `refKind` parameter
> 
> TIA

Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:

  addressing review changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4416/files
  - new: https://git.openjdk.java.net/jdk/pull/4416/files/ea47769d..a5e1c8e5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4416&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4416&range=00-01

  Stats: 19 lines in 2 files changed: 16 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4416.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4416/head:pull/4416

PR: https://git.openjdk.java.net/jdk/pull/4416


More information about the core-libs-dev mailing list