[jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

Lance Andersen lancea at openjdk.java.net
Thu Jun 17 22:15:29 UTC 2021


On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> The issue was that the attribute was processed before the variable was set (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Thanks Naoto. Updated accordingly.

Looks fine.  I still add the DataProvider name out of habit myself even though it is always the same as the method names for me (some habits are hard to break)

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/89


More information about the core-libs-dev mailing list