RFR: 8268974: jpackage fails to handle --dest option containing "bin" folder [v2]

Alexey Semenyuk asemenyuk at openjdk.java.net
Mon Jun 21 15:51:56 UTC 2021


> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin" component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath() looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so" string and then it looks for "/lib/". But this is wrong order as it should look for "/lib/" first. I.e. TruncatePath() should look for "/bin/" and then for "/lib/" if called from GetApplicationHome() and for "/lib/" first and then for "/bin/" if called from GetApplicationHomeFromDll().

Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:

  - Comments updated.
  - pathisso -> pathisdll.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4534/files
  - new: https://git.openjdk.java.net/jdk/pull/4534/files/7028e74f..18aa7427

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4534&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4534&range=00-01

  Stats: 13 lines in 1 file changed: 8 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4534.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4534/head:pull/4534

PR: https://git.openjdk.java.net/jdk/pull/4534


More information about the core-libs-dev mailing list