[jdk17] Integrated: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling

Vicente Romero vromero at openjdk.java.net
Tue Jun 22 02:11:31 UTC 2021


On Fri, 11 Jun 2021 15:01:20 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> This PR is a copy of [PR-4416](https://github.com/openjdk/jdk/pull/4416) which was intended to openjdk/jdk.
> 
> Please review this PR which is syncing the implementation of `DirectMethodHandleDesc.Kind.valueOf(int)` and `DirectMethodHandleDesc.Kind.valueOf(int, boolean)` with its spec. My reading of the method's spec is that if the value of the refKind parameter is: MethodHandleInfo.REF_invokeInterface, then DirectMethodHandleDesc.Kind.valueOf(int, boolean) should be called with a value of true for its second argument, currently it is invoked with false regardless of the value of the refKind parameter
> 
> TIA

This pull request has now been integrated.

Changeset: 6b14c8a1
Author:    Vicente Romero <vromero at openjdk.org>
URL:       https://git.openjdk.java.net/jdk17/commit/6b14c8a1e5316b6c8584e93ee7a94d9eaec676cf
Stats:     36 lines in 2 files changed: 23 ins; 8 del; 5 mod

8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling

Reviewed-by: mchung

-------------

PR: https://git.openjdk.java.net/jdk17/pull/29


More information about the core-libs-dev mailing list