[jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon" [v2]

Andy Herrick herrick at openjdk.java.net
Tue Jun 22 12:34:06 UTC 2021


On Mon, 21 Jun 2021 22:56:32 GMT, Andy Herrick <herrick at openjdk.org> wrote:

>> test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
>> 
>>> 73: 
>>> 74:         // Create another installer with custom icon.
>>> 75:         long size3 = createInstaller(customIcon, "WithCustom3Icon");
>> 
>> The test should produce WinInstallerIconTest-1.0.exe artifact referenced in SQE test spec. But this patch will not produce it. It will produce WinInstallerIconTestWithDefaultIcon-1.0.exe, WinInstallerIconTestWithCustom2Icon-1.0.exe and WinInstallerIconTestWithCustom3Icon-1.0.exe artifacts and all of them will be deleted.
>
> yes - I was changing the names to be the same length in attempt to create repeatable exe size - but that doesn't matter, so will restore the suffix's to what they were so WinInstallerIconTest-1.0.exe  will be left for JPKG001-024 in Test Spec.

done - name change and test reverted so remaining artifact is WinInstallerIconTest-1.0.exe (and it contains the custom icon)

-------------

PR: https://git.openjdk.java.net/jdk17/pull/111


More information about the core-libs-dev mailing list