[jdk17] RFR: 8269486: CallerAccessTest fails for non server variant

[David Holmes]

On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

> Hi,
> 
> please review this small fix. The test case uses a custom launcher and before launching the JVM, it adds the "lib" and "lib/server" directories to the environment variable which controls the native library search path. For non server variants, the second directory is not called "lib/server", but "lib/client", for instance.
> 
> I changed the test case to use the utility methods in `Platform` to get the correct paths, dependent on the VM variant.

This generally seems fine to me (assuming the Platform utility methods do as would be expected).

One suggestion below.

Thanks,
David

test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java line 53:

> 51: 
> 52:         String libDir = Platform.libDir().toString();
> 53:         String serverDir = Platform.jvmLibDir().toString();

Perhaps `vmDir` would be a more suitable name?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/159