[jdk17] RFR: 8269486: CallerAccessTest fails for non server variant

Christoph Göttschkes cgo at openjdk.java.net
Mon Jun 28 14:52:42 UTC 2021


On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

> Hi,
> 
> please review this small fix. The test case uses a custom launcher and before launching the JVM, it adds the "lib" and "lib/server" directories to the environment variable which controls the native library search path. For non server variants, the second directory is not called "lib/server", but "lib/client", for instance.
> 
> I changed the test case to use the utility methods in `Platform` to get the correct paths, dependent on the VM variant.

Thanks for the reviews.

> assuming the Platform utility methods do as would be expected

Yes, the utility method does the switch between "bin" and "lib" for windows and non-windows

https://github.com/openjdk/jdk17/blob/e4c5446340605b112e0918fa9dcb48aaeaa730c8/test/lib/jdk/test/lib/Platform.java#L346-L350

and it does the switch for the variant

https://github.com/openjdk/jdk17/blob/e4c5446340605b112e0918fa9dcb48aaeaa730c8/test/lib/jdk/test/lib/Platform.java#L361-L369

I only have a linux setup, so I tested this with a client and a server VM only on linux.
Sorry, I didn't enable github workflows for my jdk17 fork yet. I did so now and hopefully the next commit will trigger it.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/159


More information about the core-libs-dev mailing list