[jdk17] RFR: JDK-8269426: Move tests from test/jdk/java/lang/invoke/t8150782 to its parent directory

Jorn Vernee jvernee at openjdk.java.net
Mon Jun 28 18:16:12 UTC 2021


On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention. There are several tests under `<bugid>` directory.  As the tests under `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the parent directory.

Hi Mandy,

It looks like the test in question has some test support files associated with it (p/Foo.java & q/Bar.java). I personally think it's nice if tests like these are in a separate directory, so that it's easier to see which test support files belong to which test (and to avoid potential name clashes when 2 tests want to use a support file with the same name).

How would you feel about dropping just the `t` prefix from the test directory & package names? Then it would match the existing tests in `<bugid>` directories.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/162


More information about the core-libs-dev mailing list