RFR: 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now" [v4]

Aleksey Shipilev shade at openjdk.java.net
Mon Mar 1 08:51:01 UTC 2021


On Sun, 28 Feb 2021 10:28:56 GMT, Attila Szegedi <attila at openjdk.org> wrote:

>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now"
>
> Attila Szegedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8261483: Eliminate flakiness of the tests by using iteration number limit and explicitly running GC

Good. Minor suggestion follows.

test/jdk/jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java line 25:

> 23: 
> 24: /*
> 25:  * @test id=with_SerialGC

No need to be that explicit ("with_SerialGC"). "id=serial" should be enough.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2617


More information about the core-libs-dev mailing list