RFR: 8263105: security-libs doclint cleanup [v2]
Sean Mullan
mullan at openjdk.java.net
Tue Mar 9 16:10:17 UTC 2021
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Fix various things pointed out by the most recent doclint run in the security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running tier1/tier2 tests. Minor spot checks on generated files.
>
> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>
> Codereview Comment
src/java.base/share/classes/java/security/CodeSigner.java line 170:
> 168: /**
> 169: * Restores the state of this object from the stream, and explicitly
> 170: * reset hash code value to -1.
Change "reset" to "resets".
src/java.base/share/classes/java/security/Timestamp.java line 160:
> 158: /**
> 159: * Restores the state of this object from the stream, and explicitly
> 160: * reset hash code value to -1
s/reset/resets, and add period at end of sentence.
src/java.base/share/classes/java/security/cert/Certificate.java line 71:
> 69: private final String type;
> 70:
> 71: /** Cache the hash code for the certiticate. */
I would drop the word "Cache". Also typo: s/certiticate/certificate.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2856
More information about the core-libs-dev
mailing list