RFR: 8263105: security-libs doclint cleanup [v3]
Bradford Wetmore
wetmore at openjdk.java.net
Wed Mar 10 22:54:11 UTC 2021
On Wed, 10 Mar 2021 14:53:53 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More Codereview Comments
>
> src/java.base/share/classes/java/security/AllPermission.java line 165:
>
>> 163:
>> 164: /**
>> 165: * true if any AllPermissions have been added
>
> Please capitalize to make it a sentence, and end in ".".
Done.
> src/java.base/share/classes/java/security/BasicPermission.java line 526:
>
>> 524:
>> 525: /**
>> 526: * readObject is called to restore the state of the
>
> Ditto, capitalize.
It's the name of the method and the style is used in other packages. Leaving as is.
> src/java.base/share/classes/java/security/Permissions.java line 579:
>
>> 577: };
>> 578:
>> 579: /*
>
> The @ serialData comment can be removed entirely. It is unused due to the "@serial exclude" above.
Ok.
> src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java line 158:
>
>> 156:
>> 157: /*
>> 158: * @serialData Default field.
>
> the comment block containing @\serialdata can be omitted entirely.
ok
-------------
PR: https://git.openjdk.java.net/jdk/pull/2856
More information about the core-libs-dev
mailing list