Integrated: 8241716: Jpackage functionality to let users choose whether to create shortcuts

Alexey Semenyuk asemenyuk at openjdk.java.net
Thu Mar 11 16:58:09 UTC 2021


On Mon, 8 Mar 2021 22:54:50 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Add support to insert dialog with prompts to create shortcuts in dialog installation sequence of Windows installers created by jpackage.
> 
> Dialog look:
> ![shortcut_prompt](https://user-images.githubusercontent.com/69478316/110511049-d3828a80-80d1-11eb-8db5-392d5c11c670.png)
> 
> As a side effect of the fix, UI-related WiX source code was moved from main.wxs into generated ui.wxf file. Users can override ui.wxf by placing a file with this name in resource directory.
> Source code of custom dialogs optionally inserted in dialog installation sequence were placed in distinct WiX sources: InstallDirNotEmptyDlg.wxs and ShortcutPromptDlg.wxs. They can be overridden if files with the corresponding names as placed in resource directory.
> Moving source code of installer UI from main.wxs into ui.wxf, InstallDirNotEmptyDlg.wxs and ShortcutPromptDlg.wxs files supposed to simplify overriding of the default UI provided by jpackage.

This pull request has now been integrated.

Changeset: 7ed46bd0
Author:    Alexey Semenyuk <asemenyuk at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7ed46bd0
Stats:     3069 lines in 23 files changed: 2062 ins; 988 del; 19 mod

8241716: Jpackage functionality to let users choose whether to create shortcuts

Reviewed-by: almatvee, herrick

-------------

PR: https://git.openjdk.java.net/jdk/pull/2882


More information about the core-libs-dev mailing list