RFR: 8263552: Use String.valueOf() for char-to-String conversion in ObjectStreamClass

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Sat Mar 13 14:27:20 UTC 2021


On Sat, 13 Mar 2021 03:12:32 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/ObjectStreamClass.java line 833:
>> 
>>> 831:             String fname = in.readUTF();
>>> 832:             String signature = ((tcode == 'L') || (tcode == '[')) ?
>>> 833:                 in.readTypeString() : String.valueOf(tcode);
>> 
>> Certainly more readable and it seems that the call to valueOf is equivalent to whay takes place with the original code. I can't see any difference semantically or performance-wise at a glance. LGTM
>
> Nice cleanup. I can help file a JBS issue if @c-cleary doesn't notice your comment.

@kelthuzadx hi! I'd appreciate this, as there's no JBS issue for this (

-------------

PR: https://git.openjdk.java.net/jdk/pull/2660


More information about the core-libs-dev mailing list