RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

Rémi Forax github.com+828220+forax at openjdk.java.net
Mon Mar 15 09:35:10 UTC 2021


On Mon, 15 Mar 2021 09:21:22 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my code for updating the code in the `java.lang` package to make use of the `instanceof` pattern variable?
>> 
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8263358: Refactored missed equals method

src/java.base/share/classes/java/lang/constant/DynamicConstantDesc.java line 360:

> 358:     public final boolean equals(Object o) {
> 359:         if (this == o) return true;
> 360:         return (o instanceof DynamicConstantDesc desc)

should be
  `(o instanceof DynamicConstantDesc<?> desc)`

-------------

PR: https://git.openjdk.java.net/jdk/pull/2913


More information about the core-libs-dev mailing list