RFR: 8263560: Remove needless wrapping with BufferedInputStream [v5]
Сергей Цыпанов
github.com+10835776+stsypanov at openjdk.java.net
Mon Mar 15 17:56:11 UTC 2021
On Mon, 15 Mar 2021 15:04:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix error message
>
> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 434:
>
>> 432: int r = tmpbuf.read();
>> 433: if (r == -1) {
>> 434: logFinest("HttpClient.available(): " +
>
> There are some subtle things going on there. Using a `BufferedInputStream` ensures that all the bytes available on the socket will be read, up to the buffer capacity. Can you revert this change? I'd rather that this clean up be handled separately. I have logged https://bugs.openjdk.java.net/browse/JDK-8263599.
Sure, I'll revert this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2992
More information about the core-libs-dev
mailing list