RFR: 8263509: LdapSchemaParser.readNextTag checks array length incorrectly

Aleksei Efimov aefimov at openjdk.java.net
Tue Mar 16 10:57:10 UTC 2021


On Tue, 16 Mar 2021 08:56:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Seems fine. Lets hope no caller relies on this throwing AIOOBE. 
>> 
>> ..Thomas
>
>> This looks right but I'm surprised it isn't caught by tests (@AlekseiEfimov - do you have suggests for tests that would be useful to add here?)
> 
> Can we go without adding tests here? This seems quite trivial.

Hi @shipilev,

We do not have tests for LDAP schema parser, and creating one wouldn't be trivial: environment with real LDAP server will be needed for, at least, to collect LDAP message dumps with required schema value. Therefore, I think it is reasonable to continue without a test here.

-Aleksei

-------------

PR: https://git.openjdk.java.net/jdk/pull/2968


More information about the core-libs-dev mailing list