RFR: JDK-8263154: [macos] DMG builds have finder errors

[Andy Herrick]

On Mon, 15 Mar 2021 21:39:15 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> 
> 
> Can you explain what problem is and how it is fixed? Does it fails when "install-dir" is specified? "install-dir" is not relevant for DMG image and we should ignore it.

1.) The problem is, at least on Catalina, when in AppleScript you tell Finder to:
'make new alias file at POSIX file <payload path\> to POSIX file <install dir\> with properties {name:"<label to use\>"}'
if <install dir\> and <label to use\> are the same string, it fails
result is you don't see the folder icon to drag payload into.

This is where "install dir" does mater on DMG.  It is the folder the AppleScript will show in finder to suggest user to drag payload to.  By default this is "/Applications" but behavior is exactly the same if I set it to, for example, "~/LocalApplications". 
The fix only removes the leading slash from the label, so the folder will be labeled either "Applications" or (in my example) "Users/aherrick/LocalApplications".

-------------

PR: https://git.openjdk.java.net/jdk/pull/2987