RFR: 8263658: Use the blessed modifier order in java.base

Joe Darcy joe.darcy at oracle.com
Thu Mar 18 17:02:46 UTC 2021


On 3/18/2021 9:53 AM, Alex Blewitt wrote:
> On Thu, 18 Mar 2021 14:50:43 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>
>>> Sonar displays a warning message that modifiers should be declared in the order listed in the JLS; specifically, that isntead of using `final static` the `static final` should be preferred.
>>>
>>> This fixes the issues in the `java.base` package for ease of reviewing.
>>>
>>> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&resolved=false&rules=java%3AS1124
>> Marked as reviewed by redestad (Reviewer).
> If I have other fixes for different modules, should I file PRs with the same bug number e.g. "8263658: Use the blessed modifier order in java.logging/java.desktop" or should we have separate bug numbers for them?
>

Separate bug numbers please. It is also possible to use an umbrella 
issue and have issues for, say each module, be subtasks.

-Joe



More information about the core-libs-dev mailing list