RFR: 8263729: [test] Extend time to wait before destroying child in ProcssBuilder Basic test [v3]

[Ioi Lam]

On Fri, 19 Mar 2021 17:17:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Intermittent failures on Windows in a test of destroying the child warrant extending the time the parent waits after starting the child before destroying the child.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct redirect of stdout

LGTM. Just a small nit.

test/jdk/java/lang/ProcessBuilder/Basic.java line 2140:

> 2138:                 List<String> childArgs = new ArrayList<>(javaChildArgs);
> 2139:                 final ProcessBuilder pb = new ProcessBuilder(childArgs);
> 2140:                 {

I was a little confused until I looked up the JavaDoc of ProcessBuilder.

Maybe add a comment like "ProcessBuilder does NOT make a copy of childArgs so it's OK to modify it below"?

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3049