RFR: 8266179: [macos] jpackage should specify architecture for produced pkg files [v2]

Alexey Semenyuk asemenyuk at openjdk.java.net
Mon May 3 15:34:53 UTC 2021


On Sat, 1 May 2021 04:04:17 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> jpackage should specify architecture for produced PKG files via hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable on x64 without specifying hostArchitectures which is not correct and if install on arm Mac it will request Rosetta 2. With proposed fix by setting hostArchitectures="x86_x64" if installer contains x64 binaries, it will be installable on x64 Mac and will require Rosetta 2 on arm Mac. hostArchitectures will be set to arm64 if installer contain aarch64 binaries and will gave error when run on x64 Mac and will be installable on arm Mac without triggering installation of Rosetta 2.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8266179: [macos] jpackage should specify architecture for produced pkg files [v2]

test/jdk/tools/jpackage/macosx/HostArchPkgTest.java line 84:

> 82:     }
> 83: 
> 84:     public static void main(String[] args) throws Exception {

Please don't use direct TKit.run() call. Use jdk.jpackage.test.Annotations.Test annotation for test method. You can use SimplePackageTest jtreg test as an example

-------------

PR: https://git.openjdk.java.net/jdk/pull/3807


More information about the core-libs-dev mailing list