RFR: 8266179: [macos] jpackage should specify architecture for produced pkg files [v3]

[Alexey Semenyuk]

On Mon, 3 May 2021 20:20:52 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8266179: [macos] jpackage should specify architecture for produced pkg files [v3]
>
> test/jdk/tools/jpackage/macosx/HostArchPkgTest.java line 93:
> 
>> 91:                 .forTypes(PackageType.MAC_PKG)
>> 92:                 .addInstallVerifier(HostArchPkgTest::verifyHostArch)
>> 93:                 .run();
> 
> The test is applicable only to the scenario when .pkg installer is unpacked and not when it is installed. So `PackageTest.run()` is not quite a good fit for this execution scenario as it depends on the value of `jpackage.test.action` system property (its default value is indeed to create and unpack installer, but can be overriden). The better option would be to use `PackageTest.run()` with explicit list of actions the test should perform. Suggested fix:
> 
> new PackageTest()
>                 .forTypes(PackageType.MAC_PKG)
>                 .configureHelloApp()
>                 .addInstallVerifier(HostArchPkgTest::verifyHostArch)
>                 .run(PackageTest.Action.CREATE_AND_UNPACK);

Sorry for the inconvenience, I didn't include this comment in my initial review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3807