RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v10]

[Alan Bateman]

On Tue, 4 May 2021 12:05:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-412 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/412
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tweak comment in Module::enableNativeAccess

src/java.base/share/classes/jdk/internal/reflect/Reflection.java line 112:

> 110:         Module module = currentClass.getModule();
> 111:         if (!SharedSecrets.getJavaLangAccess().isEnableNativeAccess(module)) {
> 112:             throw new IllegalCallerException("Illegal native access from module: " + module);

You may want to drop "module" from the exception message as Module::toString is specified to return "module XXXX" or "unnamed module XXXX" so you'll end up duplication "module" in the message.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3699