RFR: 8244146: javac changes for JEP 306

[Joe Darcy]

On 5/4/2021 10:30 PM, Srikanth Adayapalam wrote:
> On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>
>> 8244146: javac changes for JEP 306
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1704:
>
>> 1702:         if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
>> 1703:             result = result & ~STRICTFP;
>> 1704:
> Nitpick: Doing in Rome as ... would mean this is better written as
>
> result &= ~STRICTFP;
>
> to be in harmony with the code in the vicinity


Sure; I had considered writing the update that way initially.


>
> Also I am OK with the feature-allowed-in-source-check, but wonder if it is an overkill for smaller focussed changes like this one. I will say I don't know what is the standard operating procedure. See that elsewhere in Lint.java you are doing
>
> if (source.compareTo(Source.JDK17) >= 0) {
>                  values.add(LintCategory.STRICTFP);
> }


Lint had some other checks directly against Source version enums, but 
I'm happy to change it to a Source.Feature-based check.

Thanks,

-Joe