RFR: 8265465: jcmd VM.cds should keep already dumped archive when exceptions happens
Yumin Qi
minqi at openjdk.java.net
Wed May 5 16:17:15 UTC 2021
Hi, Please review
When using jcmd to dump shared archive, if the archive name exists, it will be deleted first. If exception happens during dumping process, there is no new archive created. This PR changes to first dump the archive with a temporary file name. With successful dump, the temporary file will be rename to its given name. This way the old archive will not be touched on exception.
The newly added test case skipped testing on Windows since File operation result is not same as on Linux.
Tests: tier1,tier2,tier3,tier4
Thanks
Yumin
-------------
Commit messages:
- 8265465: jcmd VM.cds should keep already dumped archive when exception happens
Changes: https://git.openjdk.java.net/jdk/pull/3886/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3886&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8265465
Stats: 188 lines in 3 files changed: 158 ins; 5 del; 25 mod
Patch: https://git.openjdk.java.net/jdk/pull/3886.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3886/head:pull/3886
PR: https://git.openjdk.java.net/jdk/pull/3886
More information about the core-libs-dev
mailing list