RFR: 8266578: Disambiguate BigDecimal description of scale

Ignasi Marimon-Clos github.com+762126+ignasi35 at openjdk.java.net
Thu May 6 11:57:14 UTC 2021


On Mon, 4 Jan 2021 19:31:40 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current writeup can be missleading when presenting the meaning of a `scale` value that's negative. Hopefully, with this PR, the sentence is more clear.
>> 
>> The ambiguity is on this sentence:
>> 
>>> If negative, the unscaled value of the number is ...
>> 
>> Instead, I suggest the more verbose:
>> 
>>> If the scale is negative, the unscaled value of the number is ...
>> 
>> To keep symmetry, I've also reviewed the positive case from:
>> 
>>> If zero or positive, the scale is the number of digits ...
>> 
>> to: 
>> 
>>> If the scale is zero or positive, the scale is the number of digits ...
>
> The `jcheck` test fails because "The commit message does not reference any issue. To add an issue reference to this PR, edit the title to be of the format `issue number: message`."

Thanks @bplb. I'm afraid I'm not an [author](http://openjdk.java.net/bylaws#author) or have access to create or read the issues in [JIRA](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1).

I am a first-time crontributor and I'm unfamiliar with the specifics on contributing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/582


More information about the core-libs-dev mailing list